From bda3b63ce47bb8cdb027411a0e209f96c85b570f Mon Sep 17 00:00:00 2001 From: toshihiro Date: Fri, 24 Aug 2007 06:18:45 +0000 Subject: [PATCH] Changed: disable previewing local file 1444992 - Save dialog pops up all the time 1425029 - PHPBrowser - Saving if files are not in default workspace --- .../phpeclipse/webbrowser/views/BrowserView.java | 21 ++++++++++++------- 1 files changed, 13 insertions(+), 8 deletions(-) diff --git a/net.sourceforge.phpeclipse.webbrowser/src/net/sourceforge/phpeclipse/webbrowser/views/BrowserView.java b/net.sourceforge.phpeclipse.webbrowser/src/net/sourceforge/phpeclipse/webbrowser/views/BrowserView.java index 852b24d..c27f80a 100644 --- a/net.sourceforge.phpeclipse.webbrowser/src/net/sourceforge/phpeclipse/webbrowser/views/BrowserView.java +++ b/net.sourceforge.phpeclipse.webbrowser/src/net/sourceforge/phpeclipse/webbrowser/views/BrowserView.java @@ -17,7 +17,6 @@ import java.nio.charset.Charset; import net.sourceforge.phpeclipse.webbrowser.internal.WebBrowser; import net.sourceforge.phpeclipse.webbrowser.internal.WebBrowserUtil; -import org.eclipse.core.resources.IFile; import org.eclipse.swt.browser.Browser; import org.eclipse.swt.browser.CloseWindowListener; import org.eclipse.swt.browser.ProgressListener; @@ -170,13 +169,19 @@ public class BrowserView extends ViewPart implements IShowInTarget { return true; } } - if (context.getInput() instanceof IFile) { - IFile file = (IFile) context.getInput(); - String localhostURL; - localhostURL = "file:///" + file.getLocation().toString(); - setUrl(localhostURL); - return true; - } + // *WARNING* + // This causes unexpected behaviour such as downloading (save file). + // It depends on mime-types setting and native browser, it isn't under control of eclipse. + // (IE shows script as plain text since .php is unknown type by default. + // Mozilla downloads script file since .php is defined in mimeTypes.rdf as such.) + // + //if (context.getInput() instanceof IFile) { + // IFile file = (IFile) context.getInput(); + // String localhostURL; + // localhostURL = "file:///" + file.getLocation().toString(); + // setUrl(localhostURL); + // return true; + //} return false; } } \ No newline at end of file -- 1.7.1