Refactory: replaced internal copy of Assert class with org.eclipse.core.runtime.Assert
authorincastrix <incastrix>
Wed, 7 Oct 2009 15:33:56 +0000 (15:33 +0000)
committerincastrix <incastrix>
Wed, 7 Oct 2009 15:33:56 +0000 (15:33 +0000)
19 files changed:
net.sourceforge.phpeclipse.ui/src/net/sourceforge/phpdt/internal/ui/text/JavaAnnotationHover.java
net.sourceforge.phpeclipse.ui/src/net/sourceforge/phpdt/internal/ui/text/SmartSemicolonAutoEditStrategy.java
net.sourceforge.phpeclipse.ui/src/net/sourceforge/phpdt/internal/ui/text/template/contentassist/TemplateEngine.java
net.sourceforge.phpeclipse.ui/src/net/sourceforge/phpdt/ui/actions/GotoMatchingBracketAction.java
net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/core/JavaCore.java
net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/core/Assert.java [deleted file]
net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/core/ClasspathEntry.java
net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/core/CompilationUnitStructureRequestor.java
net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/core/DeleteElementsOperation.java
net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/core/ImportDeclaration.java
net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/core/JavaElement.java
net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/core/JavaProject.java
net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/core/SourceMethod.java
net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/core/SourceType.java
net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/core/util/Util.java
net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/corext/Assert.java [deleted file]
net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/corext/refactoring/util/ResourceUtil.java
net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/corext/util/CodeFormatterUtil.java
net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/corext/util/JdtFlags.java

index 3b564d5..a9709bd 100644 (file)
@@ -16,7 +16,9 @@ import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 
-import net.sourceforge.phpdt.internal.corext.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
 import net.sourceforge.phpdt.internal.ui.PHPUIMessages;
 //import net.sourceforge.phpeclipse.PHPeclipsePlugin;
 
index 00e57c1..f3e79b3 100644 (file)
@@ -13,7 +13,9 @@ package net.sourceforge.phpdt.internal.ui.text;
 import java.util.Arrays;
 
 import net.sourceforge.phpdt.internal.compiler.parser.Scanner;
-import net.sourceforge.phpdt.internal.core.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
 import net.sourceforge.phpdt.internal.ui.text.SmartBackspaceManager.UndoSpec;
 import net.sourceforge.phpdt.ui.PreferenceConstants;
 //import net.sourceforge.phpeclipse.PHPeclipsePlugin;
index 7d6d35d..f1d9ee5 100644 (file)
@@ -13,7 +13,9 @@ package net.sourceforge.phpdt.internal.ui.text.template.contentassist;
 import java.util.ArrayList;
 
 import net.sourceforge.phpdt.core.ICompilationUnit;
-import net.sourceforge.phpdt.internal.corext.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
 import net.sourceforge.phpdt.internal.corext.template.php.CompilationUnitContext;
 import net.sourceforge.phpdt.internal.corext.template.php.CompilationUnitContextType;
 import net.sourceforge.phpdt.internal.ui.PHPUiImages;
index ae586c0..827df31 100644 (file)
@@ -5,7 +5,9 @@ package net.sourceforge.phpdt.ui.actions;
  * All Rights Reserved.
  */
 
-import net.sourceforge.phpdt.internal.corext.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
 import net.sourceforge.phpeclipse.phpeditor.PHPEditor;
 import net.sourceforge.phpeclipse.phpeditor.PHPEditorMessages;
 
index c04e2a5..ec52806 100644 (file)
@@ -16,7 +16,10 @@ import net.sourceforge.phpdt.internal.core.JavaModel;
 import net.sourceforge.phpdt.internal.core.JavaModelManager;
 import net.sourceforge.phpdt.internal.core.Region;
 import net.sourceforge.phpdt.internal.core.util.MementoTokenizer;
-import net.sourceforge.phpdt.internal.corext.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
+
 import net.sourceforge.phpeclipse.PHPeclipsePlugin;
 
 import org.eclipse.core.resources.IFile;
diff --git a/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/core/Assert.java b/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/core/Assert.java
deleted file mode 100644 (file)
index 5cb5cd6..0000000
+++ /dev/null
@@ -1,123 +0,0 @@
-/*******************************************************************************
- * Copyright (c) 2000, 2004 IBM Corporation and others.
- * All rights reserved. This program and the accompanying materials 
- * are made available under the terms of the Common Public License v1.0
- * which accompanies this distribution, and is available at
- * http://www.eclipse.org/legal/cpl-v10.html
- * 
- * Contributors:
- *     IBM Corporation - initial API and implementation
- *******************************************************************************/
-package net.sourceforge.phpdt.internal.core;
-
-/* This class is not intended to be instantiated. */
-public final class Assert {
-
-       private Assert() {
-               // cannot be instantiated
-       }
-
-       /**
-        * Asserts that an argument is legal. If the given boolean is not
-        * <code>true</code>, an <code>IllegalArgumentException</code> is
-        * thrown.
-        * 
-        * @param expression
-        *            the outcode of the check
-        * @return <code>true</code> if the check passes (does not return if the
-        *         check fails)
-        * @exception IllegalArgumentException
-        *                if the legality test failed
-        */
-       public static boolean isLegal(boolean expression) {
-               return isLegal(expression, ""); //$NON-NLS-1$
-       }
-
-       /**
-        * Asserts that an argument is legal. If the given boolean is not
-        * <code>true</code>, an <code>IllegalArgumentException</code> is
-        * thrown. The given message is included in that exception, to aid
-        * debugging.
-        * 
-        * @param expression
-        *            the outcode of the check
-        * @param message
-        *            the message to include in the exception
-        * @return <code>true</code> if the check passes (does not return if the
-        *         check fails)
-        * @exception IllegalArgumentException
-        *                if the legality test failed
-        */
-       public static boolean isLegal(boolean expression, String message) {
-               if (!expression)
-                       throw new IllegalArgumentException(message);
-               return expression;
-       }
-
-       /**
-        * Asserts that the given object is not <code>null</code>. If this is not
-        * the case, some kind of unchecked exception is thrown.
-        * 
-        * @param object
-        *            the value to test
-        * @exception IllegalArgumentException
-        *                if the object is <code>null</code>
-        */
-       public static void isNotNull(Object object) {
-               isNotNull(object, ""); //$NON-NLS-1$
-       }
-
-       /**
-        * Asserts that the given object is not <code>null</code>. If this is not
-        * the case, some kind of unchecked exception is thrown. The given message
-        * is included in that exception, to aid debugging.
-        * 
-        * @param object
-        *            the value to test
-        * @param message
-        *            the message to include in the exception
-        * @exception IllegalArgumentException
-        *                if the object is <code>null</code>
-        */
-       public static void isNotNull(Object object, String message) {
-               if (object == null)
-                       throw new AssertionFailedException("null argument; " + message); //$NON-NLS-1$
-       }
-
-       /**
-        * Asserts that the given boolean is <code>true</code>. If this is not
-        * the case, some kind of unchecked exception is thrown.
-        * 
-        * @param expression
-        *            the outcode of the check
-        * @return <code>true</code> if the check passes (does not return if the
-        *         check fails)
-        */
-       public static boolean isTrue(boolean expression) {
-               return isTrue(expression, ""); //$NON-NLS-1$
-       }
-
-       /**
-        * Asserts that the given boolean is <code>true</code>. If this is not
-        * the case, some kind of unchecked exception is thrown. The given message
-        * is included in that exception, to aid debugging.
-        * 
-        * @param expression
-        *            the outcode of the check
-        * @param message
-        *            the message to include in the exception
-        * @return <code>true</code> if the check passes (does not return if the
-        *         check fails)
-        */
-       public static boolean isTrue(boolean expression, String message) {
-               if (!expression)
-                       throw new AssertionFailedException("Assertion failed; " + message); //$NON-NLS-1$
-               return expression;
-       }
-
-       public static class AssertionFailedException extends RuntimeException {
-               public AssertionFailedException(String detail) {
-                       super(detail);
-               }
-       }
-}
index 463e7ea..4f1cc9b 100644 (file)
@@ -22,12 +22,15 @@ import net.sourceforge.phpdt.core.JavaCore;
 import net.sourceforge.phpdt.core.JavaModelException;
 import net.sourceforge.phpdt.core.compiler.CharOperation;
 import net.sourceforge.phpdt.internal.core.util.Util;
-import net.sourceforge.phpdt.internal.corext.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+//import org.eclipse.core.runtime.Assert;
 import net.sourceforge.phpeclipse.PHPeclipsePlugin;
 
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.resources.IWorkspaceRoot;
 import org.eclipse.core.resources.ResourcesPlugin;
+import org.eclipse.core.runtime.AssertionFailedException;
 import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IPath;
 import org.eclipse.core.runtime.Path;
@@ -354,7 +357,7 @@ public class ClasspathEntry implements IClasspathEntry {
                                        false);
 
                default:
-                       throw new Assert.AssertionFailedException(Util.bind(
+                       throw new /*Assert.*/AssertionFailedException(Util.bind(
                                        "classpath.unknownKind", kindAttr)); //$NON-NLS-1$
                }
        }
@@ -1263,7 +1266,7 @@ public class ClasspathEntry implements IClasspathEntry {
                        if (path != null && path.segmentCount() >= 1) {
                                try {
                                        entry = JavaCore.getResolvedClasspathEntry(entry);
-                               } catch (Assert.AssertionFailedException e) {
+                               } catch (/*Assert.*/AssertionFailedException e) {
                                        // Catch the assertion failure and throw java model
                                        // exception instead
                                        // see bug
index d828458..66cf9f2 100644 (file)
@@ -26,7 +26,9 @@ import net.sourceforge.phpdt.internal.compiler.ISourceElementRequestor;
 import net.sourceforge.phpdt.internal.compiler.parser.Parser;
 import net.sourceforge.phpdt.internal.compiler.util.HashtableOfObject;
 import net.sourceforge.phpdt.internal.core.util.ReferenceInfoAdapter;
-import net.sourceforge.phpdt.internal.corext.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
 
 /**
  * A requestor for the fuzzy parser, used to compute the children of an
index 9096e30..9d522e7 100644 (file)
@@ -25,7 +25,9 @@ import net.sourceforge.phpdt.core.jdom.DOMFactory;
 import net.sourceforge.phpdt.core.jdom.IDOMCompilationUnit;
 import net.sourceforge.phpdt.internal.core.jdom.DOMNode;
 import net.sourceforge.phpdt.internal.core.util.Util;
-import net.sourceforge.phpdt.internal.corext.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
 
 /**
  * This operation deletes a collection of elements (and all of their children).
index 73a103f..9718799 100644 (file)
@@ -14,6 +14,9 @@ import net.sourceforge.phpdt.core.IImportDeclaration;
 import net.sourceforge.phpdt.core.IJavaElement;
 import net.sourceforge.phpdt.core.JavaModelException;
 import net.sourceforge.phpdt.core.jdom.IDOMNode;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
 
 /**
  * Handle for an import declaration. Info object is a
index 3afb507..f5640d2 100644 (file)
@@ -30,7 +30,9 @@ import net.sourceforge.phpdt.core.jdom.IDOMCompilationUnit;
 import net.sourceforge.phpdt.core.jdom.IDOMNode;
 import net.sourceforge.phpdt.internal.core.util.MementoTokenizer;
 import net.sourceforge.phpdt.internal.core.util.Util;
-import net.sourceforge.phpdt.internal.corext.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
 
 import org.eclipse.core.resources.IResource;
 import org.eclipse.core.resources.IResourceStatus;
index 988a718..8523713 100644 (file)
@@ -51,7 +51,9 @@ import net.sourceforge.phpdt.internal.codeassist.ISearchableNameEnvironment;
 import net.sourceforge.phpdt.internal.compiler.util.ObjectVector;
 import net.sourceforge.phpdt.internal.core.util.MementoTokenizer;
 import net.sourceforge.phpdt.internal.core.util.Util;
-import net.sourceforge.phpdt.internal.corext.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
 import net.sourceforge.phpeclipse.LoadPathEntry;
 import net.sourceforge.phpeclipse.PHPeclipsePlugin;
 
@@ -66,6 +68,7 @@ import org.eclipse.core.resources.IResource;
 import org.eclipse.core.resources.IWorkspace;
 import org.eclipse.core.resources.IWorkspaceRoot;
 import org.eclipse.core.resources.ResourcesPlugin;
+import org.eclipse.core.runtime.AssertionFailedException;
 import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IPath;
 import org.eclipse.core.runtime.IProgressMonitor;
@@ -1007,7 +1010,7 @@ public class JavaProject extends Openable implements IJavaProject,
                                                + "/.classpath, will mark classpath as invalid"); //$NON-NLS-1$
                        }
                        return INVALID_CLASSPATH;
-               } catch (Assert.AssertionFailedException e) {
+               } catch (/*Assert.*/AssertionFailedException e) {
                        // failed creating CP entries from file
                        if (createMarker && this.getProject().isAccessible()) {
                                this
index af20570..f7d2e0b 100644 (file)
@@ -18,7 +18,9 @@ import net.sourceforge.phpdt.core.Signature;
 import net.sourceforge.phpdt.core.jdom.IDOMMethod;
 import net.sourceforge.phpdt.core.jdom.IDOMNode;
 import net.sourceforge.phpdt.internal.core.util.Util;
-import net.sourceforge.phpdt.internal.corext.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
 
 /**
  * @see IMethod
index 02bd1bc..ed6e792 100644 (file)
@@ -25,7 +25,9 @@ import net.sourceforge.phpdt.core.IWorkingCopy;
 import net.sourceforge.phpdt.core.JavaModelException;
 import net.sourceforge.phpdt.core.jdom.IDOMNode;
 import net.sourceforge.phpdt.internal.core.util.Util;
-import net.sourceforge.phpdt.internal.corext.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
 
 import org.eclipse.core.runtime.IProgressMonitor;
 
index 09ace1c..0661b89 100644 (file)
@@ -31,7 +31,9 @@ import net.sourceforge.phpdt.core.JavaModelException;
 import net.sourceforge.phpdt.core.Signature;
 import net.sourceforge.phpdt.core.compiler.CharOperation;
 import net.sourceforge.phpdt.internal.compiler.ast.TypeReference;
-import net.sourceforge.phpdt.internal.core.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
 //import net.sourceforge.phpdt.internal.core.PackageFragmentRoot;
 import net.sourceforge.phpdt.internal.core.util.PHPFileUtil;
 
diff --git a/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/corext/Assert.java b/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/corext/Assert.java
deleted file mode 100644 (file)
index 662ccdc..0000000
+++ /dev/null
@@ -1,141 +0,0 @@
-/*
- * (c) Copyright IBM Corp. 2000, 2001.
- * All Rights Reserved.
- */
-package net.sourceforge.phpdt.internal.corext;
-
-// import
-// org.phpeclipse.phpdt.internal.corext.refactoring.RefactoringCoreMessages;
-
-/**
- * <code>Assert</code> is useful for for embedding runtime sanity checks in
- * code. The static predicate methods all test a condition and throw some type
- * of unchecked exception if the condition does not hold.
- * <p>
- * Assertion failure exceptions, like most runtime exceptions, are thrown when
- * something is misbehaving. Assertion failures are invariably unspecified
- * behavior; consequently, clients should never rely on these being thrown (or
- * not thrown). <b>If you find yourself in the position where you need to catch
- * an assertion failure, you have most certainly written your program
- * incorrectly.</b>
- * </p>
- * <p>
- * Note that an <code>assert</code> statement is slated to be added to the
- * Java language in JDK 1.4, rending this class obsolete.
- * </p>
- */
-public final class Assert {
-
-       /**
-        * <code>AssertionFailedException</code> is a runtime exception thrown by
-        * some of the methods in <code>Assert</code>.
-        * <p>
-        * This class is not declared public to prevent some misuses; programs that
-        * catch or otherwise depend on assertion failures are susceptible to
-        * unexpected breakage when assertions in the code are added or removed.
-        * </p>
-        */
-       public static class AssertionFailedException extends RuntimeException {
-
-               /**
-                * Constructs a new exception.
-                */
-               public AssertionFailedException() {
-               }
-
-               /**
-                * Constructs a new exception with the given message.
-                */
-               public AssertionFailedException(String detail) {
-                       super(detail);
-               }
-       }
-
-       /* This class is not intended to be instantiated. */
-       private Assert() {
-       }
-
-       /**
-        * Asserts that the given object is not <code>null</code>. If this is not
-        * the case, some kind of unchecked exception is thrown.
-        * <p>
-        * As a general rule, parameters passed to API methods must not be
-        * <code>null</code> unless <b>explicitly</b> allowed in the method's
-        * specification. Similarly, results returned from API methods are never
-        * <code>null</code> unless <b>explicitly</b> allowed in the method's
-        * specification. Implementations are encouraged to make regular use of
-        * <code>Assert.isNotNull</code> to ensure that <code>null</code>
-        * parameters are detected as early as possible.
-        * </p>
-        * 
-        * @param object
-        *            the value to test
-        */
-       public static void isNotNull(Object object) {
-               // succeed as quickly as possible
-               if (object != null) {
-                       return;
-               }
-               isNotNull(object, ""); //$NON-NLS-1$
-       }
-
-       /**
-        * Asserts that the given object is not <code>null</code>. If this is not
-        * the case, some kind of unchecked exception is thrown. The given message
-        * is included in that exception, to aid debugging.
-        * <p>
-        * As a general rule, parameters passed to API methods must not be
-        * <code>null</code> unless <b>explicitly</b> allowed in the method's
-        * specification. Similarly, results returned from API methods are never
-        * <code>null</code> unless <b>explicitly</b> allowed in the method's
-        * specification. Implementations are encouraged to make regular use of
-        * <code>Assert.isNotNull</code> to ensure that <code>null</code>
-        * parameters are detected as early as possible.
-        * </p>
-        * 
-        * @param object
-        *            the value to test
-        * @param message
-        *            the message to include in the exception
-        */
-       public static void isNotNull(Object object, String message) {
-               if (object == null)
-                       throw new AssertionFailedException("nullargument" + message); //$NON-NLS-1$
-       }
-
-       /**
-        * Asserts that the given boolean is <code>true</code>. If this is not
-        * the case, some kind of unchecked exception is thrown.
-        * 
-        * @param expression
-        *            the outcome of the check
-        * @return <code>true</code> if the check passes (does not return if the
-        *         check fails)
-        */
-       public static boolean isTrue(boolean expression) {
-               // succeed as quickly as possible
-               if (expression) {
-                       return true;
-               }
-               return isTrue(expression, ""); //$NON-NLS-1$
-       }
-
-       /**
-        * Asserts that the given boolean is <code>true</code>. If this is not
-        * the case, some kind of unchecked exception is thrown. The given message
-        * is included in that exception, to aid debugging.
-        * 
-        * @param expression
-        *            the outcome of the check
-        * @param message
-        *            the message to include in the exception
-        * @return <code>true</code> if the check passes (does not return if the
-        *         check fails)
-        */
-       public static boolean isTrue(boolean expression, String message) {
-               if (!expression)
-                       throw new AssertionFailedException("assertion failed" + message); //$NON-NLS-1$
-               return expression;
-       }
-
-}
index 2983884..cca176a 100644 (file)
@@ -17,7 +17,9 @@ import net.sourceforge.phpdt.core.ICompilationUnit;
 import net.sourceforge.phpdt.core.IJavaElement;
 import net.sourceforge.phpdt.core.IMember;
 import net.sourceforge.phpdt.core.IOpenable;
-import net.sourceforge.phpdt.internal.corext.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
 
 import org.eclipse.core.resources.IFile;
 import org.eclipse.core.resources.IResource;
index 00bc0ea..5d1989d 100644 (file)
@@ -14,7 +14,9 @@ package net.sourceforge.phpdt.internal.corext.util;
 
 import net.sourceforge.phpdt.core.ToolFactory;
 import net.sourceforge.phpdt.core.formatter.DefaultCodeFormatterConstants;
-import net.sourceforge.phpdt.internal.corext.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
 import net.sourceforge.phpeclipse.PHPeclipsePlugin;
 
 import org.eclipse.core.runtime.Preferences;
index cdb35a0..a16877f 100644 (file)
@@ -17,7 +17,9 @@ import net.sourceforge.phpdt.core.IJavaElement;
 import net.sourceforge.phpdt.core.IMember;
 import net.sourceforge.phpdt.core.IType;
 import net.sourceforge.phpdt.core.JavaModelException;
-import net.sourceforge.phpdt.internal.corext.Assert;
+//incastrix
+//import net.sourceforge.phpdt.internal.corext.Assert;
+import org.eclipse.core.runtime.Assert;
 
 public class JdtFlags {
        private JdtFlags() {